Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math magicians: components #2

Merged
merged 8 commits into from May 24, 2022
Merged

Math magicians: components #2

merged 8 commits into from May 24, 2022

Conversation

jmoseka
Copy link
Owner

@jmoseka jmoseka commented May 24, 2022

In this PR I have

  • Deleted all the boilerplate from CRA (text, images, styles).
  • Created a directory called components.
  • Inside components, created a new Calculator.js file.
  • In Calculator.js, created a React component that matches this design

@omar-labana
Copy link

Approved ✔️

Hi @jmoseka

Congratulations on completing this project! 👏🏼 🎉

You have correctly implemented all of the requirements📃 correctly and without any errors⚠️ or bugs🪲.

Cheers and good luck in your next milestones! 🍀

Feel free to leave any questions or comments in the PR thread(don't forget to tag me 😄) if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@jmoseka jmoseka merged commit dd295aa into dev May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants