Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math magicians: full website #5

Merged
merged 2 commits into from May 31, 2022
Merged

Math magicians: full website #5

merged 2 commits into from May 31, 2022

Conversation

jmoseka
Copy link
Owner

@jmoseka jmoseka commented May 31, 2022

In this PR, I have done the following

  • add 3 pages (home, calculator, and quote)
  • the general layout matches this wireframe
  • add personal styling to improve the look and feel
  • for every page, there is a route
  • the navigation links for all 3 routes are displayed on each page

Copy link

@elmar8287 elmar8287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

APPROVED 👍 🥇

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:

Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@jmoseka jmoseka merged commit 95d0ab0 into dev May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants