Math Magicians: tests #6
Conversation
There was a problem hiding this comment.
Hi @jmoseka,
Great job so far 👏 💯 👍. However, there are few issues we need to address before we move on. Please, check the comments below.
Highlights
- Follows git workflow. 💯
- Codebase looks clean and professional. 💯
Required Changes ♻️
- [ ] There is one test that is failing. Kindly fix it.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
Issue fixed. Put the correct import file name inside Calculator.test.js file and removed the ESlint disable comment |
There was a problem hiding this comment.
Hi @jmoseka,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- No linter errors. ✔️
- GitHub flow is followed. ✔️
- Professional README file. ✔️
- PR has a good title and summary. ✔️
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In this PR, we
Set up React Testing Library.
Write unit tests for the files operate.js and calculate.js using Jest.
Created unit tests for all React components:
Use Jest snapshots to test the components.
Use React Testing Library to simulate user interaction.