-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TabsRoute behaviour #17
Comments
This is supported when root route,
This is in the README under Advanced Usage. It is possible with a custom route reducer. But we should probably make this the default behavior. 🍺 |
Can the state also include its scroll position? |
The F8 app does this, uses NavExp and is open source. So it should be possible. Haven't investigated this in detail but it's a must-have for sure. |
@jonathanewerner @joonhocho That is supported. Previously, there was a bug in NavigationExperimental that dropped component state when swtiching tabs. But that's now fixed, and UINavigationContoller extends UIViewController and uses the good old lifecycles inherited from it. It does retain all
|
Thanks @jmurzy for such detailed answer. |
Any movement on this? This is quite limiting and is stopping me from truly being able to use this on my app. Switching between tabs does not retain that tabs state and instead pushed the new route on top. I also don't know enough to write my own reducer, that seems that's pretty involved. |
TabsRoute should implement two behaviours:
Given the following route config:
Visiting routes should lead to the following results respectively:
The text was updated successfully, but these errors were encountered: