Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n_simulations = None #10

Open
SylwiaKolodziejska opened this issue Jul 29, 2020 · 2 comments
Open

n_simulations = None #10

SylwiaKolodziejska opened this issue Jul 29, 2020 · 2 comments

Comments

@SylwiaKolodziejska
Copy link

SylwiaKolodziejska commented Jul 29, 2020

It is possible to add new feature like using n_simulation = None in 'MarkovModel'?

It throws me an error it must be an integer, but in docsting i have information like that:

'n_simulations : one of {int, None}; default=10000'

'"Traceback (most recent call last):
File "", line 1, in
TypeError: 'NoneType' object cannot be interpreted as an integer
"'

I need do something like nsim = NULL in 'markov_model' in 'ChannelAttribution' package in R, these two algorithms are similarly implemented.

for i in range(nsim):

@bnebeker
Copy link

What does the R package do when it's set to NULL, just set it to default?

@SylwiaKolodziejska
Copy link
Author

In 1.18 version 'ChannelAttributtion' in R, a package set nsim = NULL or 0 to 1e6 (1 000 000).

But in the latest version from 27.07.2020 we have nsim_start parameter and its default value is 1e5.

I checked that 'pychattr' (Python) doesn`t support value None but it supports n_simulations = 0 and it sets n_simulations to 1e6.

Regards,
Sylwia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants