Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring directory structure #41

Open
maheshkelkar opened this issue Jun 1, 2015 · 4 comments
Open

Refactoring directory structure #41

maheshkelkar opened this issue Jun 1, 2015 · 4 comments

Comments

@maheshkelkar
Copy link
Contributor

Currently all the files/modules are located in top package level agent directory.

@cyrille-leclerc let me know if you are ok if I restructure the modules into separate directories? It will really help with manageability.

E.g.
com.jmxtrans.agent

  • util - contains utility (as-is)
  • outputWriter - contains abstract & derived writers
  • resultNameStrategy - contains result name transform code (as-is)
  • agent, agent builder, query, invocations, etc. code resides in the top level dir
@kerlandsson
Copy link
Member

Cleaning up the directory structure would be appreciated. However, since several classes are referenced by qualified name in the configuration (e.g. output writers) file we cannot move them without breaking backwards compatibility.

@gliptak
Copy link
Contributor

gliptak commented Oct 22, 2016

What would be a good approach to backwards compatibility for a refactoring like this? When do you see deprecated being removed?

@kerlandsson
Copy link
Member

@gliptak In my opinion, the benefits of cleaning up the directory structure are not big enough to warrant breaking existing configurations. I would suggest an approach where we try to move things that are not referenced in the configuration file and let the rest be.

@cyrille-leclerc
Copy link
Member

+1 on @kerlandsson's proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants