Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermediate images do not have a transparent background #55

Closed
leoheck opened this issue May 20, 2021 · 6 comments
Closed

Intermediate images do not have a transparent background #55

leoheck opened this issue May 20, 2021 · 6 comments

Comments

@leoheck
Copy link
Contributor

leoheck commented May 20, 2021

Only the final image has this transparent bg.
image

The default viewer shows this composition of images with the diff image in the center.

Using my own img-diff here to store temporary images does not have the new background, unfortunattely =/

➜ plotgitsch HEAD~5 HEAD~4 --colors=FF0000:00FF00:000000:FFFFFF80
use compare (ImageMagick) between bitmaps between Git rev HEAD~5 and Git rev HEAD~4
Exporting...
sch1-board.svg (41c834)
sch2-board.svg (4f9c66)

Could you propagate this to the source image?

@leoheck
Copy link
Contributor Author

leoheck commented May 20, 2021

Ah, a flag to keep the originals would be super good to have! I am using my own git-imgdiff just to save these files.

@leoheck
Copy link
Contributor Author

leoheck commented May 20, 2021

This flag one could keep the originals too.

-k, --keep
by default, the svg diff files are deleted after launching the
viewer; this option lets the files in place after viewing them.

Oh, I already have an issue with this, #52

@jnavila
Copy link
Owner

jnavila commented May 21, 2021

This change involves more rework than what I expected.

@leoheck
Copy link
Contributor Author

leoheck commented May 21, 2021

My bad!

I am following your changes. It looks like you have to change a lot of files for every small feature. Is this something related to the OCaml itself or the features you are changing are not small as I was thinking.

@jnavila
Copy link
Owner

jnavila commented May 21, 2021

The span of changes is mostly due to the chain spanning from commandline argument to low level kicadlib stuff. It seems a lot of volume but it's not a big deal.

This one is more complicated, because the color scheme option is tied to the diffing process when it's internal. What the feature requests is a change in how the schematics are drawn, which is different. In fact, these should be two separated options.

@leoheck leoheck changed the title Transparent bg is add only to the diff image Transparent bg is added only to the final image May 21, 2021
@leoheck leoheck changed the title Transparent bg is added only to the final image Intermediate images do not have a transparent background Feb 17, 2022
@leoheck
Copy link
Contributor Author

leoheck commented Feb 17, 2022

Since this is pretty hard to implement I am going to close this issue now. This can be addressed externally in the git-imagediff script, for instance by just replacing the color in the generated images, directly.

@leoheck leoheck closed this as completed Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants