Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hand drawn effects #3

Open
mkarliner opened this issue Apr 20, 2020 · 3 comments
Open

Hand drawn effects #3

mkarliner opened this issue Apr 20, 2020 · 3 comments

Comments

@mkarliner
Copy link

mkarliner commented Apr 20, 2020

It's a very nice concept!

I feel that as it's a whiteboard, it could use
a little more of an informal feel, as in:
https://codepen.io/tmrDevelops/pen/NPXodB

I've had a go at including this, and the boxes work fine, but
I suspect that the lines may need a different technique than a
zero height box.

also, a more informal font would be nice.

@jncraton
Copy link
Owner

Thanks for this feedback. I'll certainly give it some thought.

Right now, this would be challenging to implement, as the architecture is currently very simple and assumes that everything lives on a 64px grid. If that assumption is broken, elements would have to become aware of their neighbors in order to make everything connect properly. That can certainly be done, but it unfortunately isn't as simple as a style change.

@mkarliner
Copy link
Author

Yes, I think svg would be the way to go, but obviously at the cost
of considerably more complexity. However, the idea is so attractive
that I think it deserves the makeover. You may look at https://github.com/pshihn/rough
I'm not really a front end person, but I'd be willing to help.

@jncraton
Copy link
Owner

jncraton commented Jul 7, 2020

I've been playing around with implementing this. Here's the current state showing the curved CSS border concept:

https://hand-drawn--box-line-text.netlify.app/#;f1133Hello;9422;e6133World

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants