Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go through the im-rs PRs #2

Closed
24 of 25 tasks
jneem opened this issue Aug 8, 2021 · 4 comments
Closed
24 of 25 tasks

Go through the im-rs PRs #2

jneem opened this issue Aug 8, 2021 · 4 comments

Comments

@jneem
Copy link
Owner

jneem commented Aug 8, 2021 •
edited

  • 104 (improve vec iterator performance. Has some bugs, but probably worthwhile fixing it up)
  • 150
  • 154
  • 155 (clone for by-ref iterators. Blocked on changes to sized-chunks)
  • 158
  • 160 (Make empty hashmaps not depend on random state. I think this is better fixed by making hashmaps non-Hash (and maybe also non-Ord, see #175)
  • 161 (Adds a convenience method, seems worthwhile. Get it in after 1.0, because 1.0 shouldn't change API)
  • 163 (Merge smaller maps into larger ones)
  • 164
  • 165
  • 168 (Lifetime change; not sem-ver compatible, so after 1.0)
  • 170
  • 173
  • 176
  • 177
  • 178
  • 179
  • 180
  • 183
  • 184
  • 186
  • 189
  • 191
  • 192
  • 193
@jneem
Copy link
Owner Author

jneem commented Aug 8, 2021

Got our own dependabot set up, so marking all the dependabot PRs as done.

@jneem
Copy link
Owner Author

jneem commented Nov 26, 2021

Addressing im PR 160 in #40

@jneem
Copy link
Owner Author

jneem commented Apr 11, 2022

Im PR 155 was done in #55

@jneem
Copy link
Owner Author

jneem commented Apr 11, 2022

Gonna go ahead and close this, despite leaving 104 unaddressed. I'd like to get better benchmarking infrastructure in place before doing optimization.

@jneem jneem closed this as completed Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jneem