Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in R highlighter #382

Closed
jeroen opened this issue Feb 2, 2016 · 7 comments
Closed

Bug in R highlighter #382

jeroen opened this issue Feb 2, 2016 · 7 comments

Comments

@jeroen
Copy link

jeroen commented Feb 2, 2016

The R highlighter does something weird to the final line of a comment: https://www.opencpu.org/posts/commonmark-fast/

@BruceZhaoR
Copy link

In R code the keywords,such as library, don't render correctly. I check the source file and find that the R keyword is span.n, which means normal. But in the pygments highlighter, it is span.k, which meas keyword.
I can't figure out why pygments should be repalced by rouge!

@klmr
Copy link
Contributor

klmr commented Feb 4, 2016

@BruceZhaoR The bug report is unconcerned with the lack of highlighting of function names; the issue is, rather, that the last line of the comment is wrongly highlighted:

screenshot

I can't figure out why pygments should be repalced by rouge!

The move may have been premature but there are good reasons for it: Jekyll itself runs in Ruby, and having to invoke a separate interpreter to use a library written in another language (Python) is potentially vastly less efficient than using a library written in the same language.

@BruceZhaoR
Copy link

@klmr Sorry about that! New things always take time to adapt. Hope somebody could implement the highlighting of R function names. 😃

@BruceZhaoR
Copy link

I borrowed a set of js file from RStudio,and now it works fine. If you want to make your R highlight nicer,you could go to look the brucezhaor.github.iorepository.

@klmr
Copy link
Contributor

klmr commented Feb 9, 2016

@BruceZhaoR There’s #383 as well.

@miparnisari
Copy link
Contributor

This looks OK in version 3.4.1.

image

@pyrmont
Copy link
Contributor

pyrmont commented Jun 13, 2019

@miparnisari Yeah, #383 was merged in. Thanks for rooting out these stale issues :)

@pyrmont pyrmont closed this as completed Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants