Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Conflict with Tempsgraph #9

Closed
Desterly opened this issue Apr 17, 2018 · 6 comments
Closed

Plugin Conflict with Tempsgraph #9

Desterly opened this issue Apr 17, 2018 · 6 comments
Labels
bug Something isn't working

Comments

@Desterly
Copy link

Desterly commented Apr 17, 2018

There is currently a conflict between BedLevelVisualizer and Tempsgraph (https://github.com/1r0b1n0/OctoPrint-Tempsgraph).

Tempsgraph is currently utilizing Plotly 1.33.1 which either the version of the distribution of it does not contain the "react" function causing the graph to not load.

Based on plugin load order and optimization, the resulting version of plotly loaded is the 1.33.1 version not the 1.35.2 needed for BedLevelVisualizer

Not sure if the two versions can be isolated by aliasing plotly or simply be brought into sync with version numbers.

Corresponding ticket for the other plugin (1r0b1n0/OctoPrint-Tempsgraph#15)

@GhostlyCrowd
Copy link

Ah so this is why I don't get the graph either. Was just coming to report this.

@jneilliii
Copy link
Owner

Thanks for the detailed report. Hopefully TempsGraph can upgrade without issue. Not sure I can downgrade or not.

@Desterly
Copy link
Author

Seems to be fine with the upgrade. I created a pull request.

@jneilliii
Copy link
Owner

Awesome, thanks for doing all the leg work @Desterly. Hopefully @1r0b1n0 will merge.

@jneilliii jneilliii added bug Something isn't working wontfix labels Apr 19, 2018
@jneilliii
Copy link
Owner

Closing in preference for keeping the react function of Plotly for improved performance, hopefully the pull request is merged.

@TheLion
Copy link

TheLion commented Feb 9, 2019

On my iPad there still is a conflict between these plugins. When I remove Tempsgraph plugin, the error disappears and the BedLevelVisualizer is displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants