Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package not working for certain shapes #3

Open
james-shuster opened this issue Nov 19, 2020 · 2 comments
Open

Package not working for certain shapes #3

james-shuster opened this issue Nov 19, 2020 · 2 comments
Assignees

Comments

@james-shuster
Copy link

james-shuster commented Nov 19, 2020

Hello there,

First off thanks for making this package available - i've searched long and hard for a python package for automated rectangle decomposition.

I have had success using this package for certain arrays, however for many arrays the returned rectangles are not optimized.

From the attached you can see 2 arrays, 1 working and 1 not working.

Upon inspection of the not working rectangles that were returned, they are actually all 1 point (4 repeated values of the same x,y coordinate). I compared the 2 arrays (workings vs non working) and i cannot see any difference in the 2 (same sig figs, same structure etc..) Please also find these arrays attached (left = not working, right = working).

I would really appreciate it if you could get back to me with your thoughts on this.

Take care,

James
working_array
not_working_array
rectangles
arrays

@jnfran92
Copy link
Owner

Hi, sorry the long delay, I am optimizing the library now, Can you please share me the files which you tested? @james-shuster

@jnfran92 jnfran92 self-assigned this Oct 20, 2022
@UralmashFox
Copy link

Absolutely the same problem. The return contains a single point
plswork.csv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants