Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaVM should be Clone #503

Closed
jrose-signal opened this issue Oct 5, 2023 · 1 comment · Fixed by #478
Closed

JavaVM should be Clone #503

jrose-signal opened this issue Oct 5, 2023 · 1 comment · Fixed by #478

Comments

@jrose-signal
Copy link
Contributor

JavaVM wraps a virtual dispatch table that's assumed to have 'static lifetime, and exposes from_raw and get_java_vm_pointer, with no Drop glue. It should implement Clone, since there is no cost to doing so.

Note that JavaVM could even implement Copy, but it could reasonably be argued that that might prevent a future improvements to JavaVM.
@argv-minus-one
Copy link
Contributor

That's planned in #478.

@argv-minus-one argv-minus-one linked a pull request Oct 6, 2023 that will close this issue
Ports jni to the proposed jni-sys 0.4 API #478
Merged
6 tasks
@rib rib closed this as completed in #478 Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ports jni to the proposed jni-sys 0.4 API jni-rs/jni-rs
2 participants
@argv-minus-one @jrose-signal