Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing the Option around all JNI 1.1 methods that aren't optional #20

Closed
rib opened this issue Jun 9, 2023 · 1 comment
Closed

Consider removing the Option around all JNI 1.1 methods that aren't optional #20

rib opened this issue Jun 9, 2023 · 1 comment

Comments

@rib
Copy link
Contributor

rib commented Jun 9, 2023

This came up in discussion here: jni-rs/jni-rs#432 (comment)

It was also noted that, even for the newer methods an Option is probably not appropriate since these would be indexing off the end of the original JNI 1.1 function table on older implementations, so there's presumably no guarantee that they would be NULL.
@rib
Copy link
Contributor Author

rib commented Aug 31, 2023

This was addressed by #25

@rib rib closed this as completed Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rib