Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubies; Remove BUNDLE_JOBS as it's not respected by Travis #1465

Merged
merged 1 commit into from Jan 19, 2015

Conversation

abotalov
Copy link
Collaborator

No description provided.

@twalpole
Copy link
Member

Is not respecting BUNDLE_JOBS a new change on Travis?? I'm pretty sure it used to respect it

@abotalov
Copy link
Collaborator Author

See:
calagator/calagator@87169d0
teampoltergeist/poltergeist#499 (comment)

After some search in travis-build/travis-build I found that first commit that added --jobs=3 is probably this one - travis-ci/travis-build@6cb7c4d and current implementation seems to be here (https://github.com/travis-ci/travis-build/blob/a9f5fe32fffb4d4ceee2062770c7c50aa3098d3a/lib/travis/build/script/shared/bundler.rb). Though I don't know Travis structure, I've just searched through it.

So travis-build sets --jobs=3 without checking for BUNDLE_JOBS env variable. Probably this is a bug in Travis but I think --jobs=3 is fine for us.

cc @joshk

twalpole added a commit that referenced this pull request Jan 19, 2015
Update rubies; Remove BUNDLE_JOBS as it's not respected by Travis
@twalpole twalpole merged commit 0ce0102 into teamcapybara:master Jan 19, 2015
@twalpole
Copy link
Member

ok 3 vs 4 wouldn't make much difference anyway -- merging -- thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants