Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one test is failing -- CarrierWave::Uploader::Download#download! should not obscure original exception message #1080

Closed
pravi opened this issue Apr 30, 2013 · 2 comments

Comments

@pravi
Copy link

pravi commented Apr 30, 2013

I suspect it is a test that needing an update.

Failures:

  1) CarrierWave::Uploader::Download#download! should not obscure original exception message
     Failure/Error: expect {
       expected CarrierWave::DownloadError with "could not download file: 404 ", got #<CarrierWave::DownloadError: could not download file: 404 Not Found> with backtrace:
         # ./lib/carrierwave/uploader/download.rb:41:in `rescue in file'
         # ./lib/carrierwave/uploader/download.rb:34:in `file'
         # ./lib/carrierwave/uploader/download.rb:24:in `respond_to?'
         # ./lib/carrierwave/sanitized_file.rb:94:in `size'
         # ./lib/carrierwave/sanitized_file.rb:135:in `empty?'
         # ./lib/carrierwave/uploader/cache.rb:119:in `cache!'
         # ./lib/carrierwave/uploader/download.rb:61:in `download!'
         # ./spec/uploader/download_spec.rb:107:in `block (4 levels) in <top (required)>'
         # ./spec/uploader/download_spec.rb:106:in `block (3 levels) in <top (required)>'
     # ./spec/uploader/download_spec.rb:106:in `block (3 levels) in <top (required)>'

Finished in 15.77 seconds
1025 examples, 1 failure

Failed examples:

rspec ./spec/uploader/download_spec.rb:105 # CarrierWave::Uploader::Download#download! should not obscure original exception message
rake aborted!
@bensie
Copy link
Member

bensie commented Apr 30, 2013

Looks like it -- mind submitting a PR to fix it?

@pravi
Copy link
Author

pravi commented Apr 30, 2013

@bensie it was fixed a month ago by @hsbt

@pravi pravi closed this as completed Apr 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants