Upgrade capybara to 2 1 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctional part that mater (the timeout function) to evergreen.
|
I'll remove 1.9.2 as a ruby version we test against, and hopefully get this in. Much appreciated @victormartins! |
|
My pleasure :) 👍 |
|
Might do this as a major release given the change to support 1.9.3, what do you think? |
|
I think there is no need for that. The API didn't change, no functional changes either. It's just versions. Right? |
| s.add_runtime_dependency("launchy") | ||
| s.add_runtime_dependency("sinatra", ["~> 1.1"]) | ||
| s.add_runtime_dependency("json_pure") | ||
| s.add_runtime_dependency("coffee-script") | ||
|
|
||
| s.add_development_dependency('rspec', ['~> 2.0']) | ||
| s.add_development_dependency('capybara-webkit', ['~>0.7']) | ||
| s.add_development_dependency('capybara-webkit') |
There was a problem hiding this comment.
Not sure if this should be s.add_development_dependency('capybara-webkit', ['=>0.7']) ?
There was a problem hiding this comment.
I guess the webkit version is handled by capybara version being higher than 2.0, I guess the flexibility is better when including this in a rails app
|
@jnicklas Does this warrant a bump in version to 2.0, or 1.1.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading capybara to 2.1 and running the specs, I've noticed that it only had one problem. Capybara deprecated the method wait_until, as explained here: http://www.elabs.se/blog/53-why-wait_until-was-removed-from-capybara
Evergreen only used that method in one place, and, as far as I know, it was only to prevent the evergreen tests to hang forever. So, I moved the timout helper ( that wait_until used ) to evergreen and used it in replace of wait_until.
Specs are passing, so it seems ok.
Can you review this please?
Thanks.