Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 41 #42

Merged
merged 2 commits into from Jun 4, 2012
Merged

Fix issue 41 #42

merged 2 commits into from Jun 4, 2012

Conversation

cap10morgan
Copy link
Contributor

This fixes issue #41 and adds specs for it. The only change is to also search for type="reset" in the HTML.button method.

@cap10morgan
Copy link
Contributor Author

I'm not sure why GH decided to create a new issue rather than associating this with issue #41. Sorry about that.

@jnicklas
Copy link
Collaborator

jnicklas commented Jun 4, 2012

Doesn't seem particularly useful to me, but I can't argue with the correctness, so in it goes...

jnicklas added a commit that referenced this pull request Jun 4, 2012
@jnicklas jnicklas merged commit 79766e2 into teamcapybara:master Jun 4, 2012
@cap10morgan
Copy link
Contributor Author

Here's my use case in case it matters: I'm using a jQuery form wizard plugin that uses the type="reset" button as the "back" button for each wizard step. Without this fix, Capybara couldn't find these buttons on the page.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants