PR: Vectorization of the "heatpump" module #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jnsebgosselin! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on July 09, 2018 at 02:16 Hours UTC |
jnsebgosselin
added
type: new feature
type: refactoring
type: continuous integration
and removed
type: new feature
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coolingandheatingmodeTinHP,Vf, andqbatare now all defined as numpy arrays.COP,CAP,ToutHP, andTmall return numpy arrays.When calculating the
COPandToutHPfor every value ofTinHP, the program uses the equations and property tables for cooling for every index whereqbat < 0and heating whereqbat >= 0.