Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen resolution not detected on every device #1

Closed
jNullj opened this issue Jul 22, 2022 · 1 comment
Closed

Screen resolution not detected on every device #1

jNullj opened this issue Jul 22, 2022 · 1 comment

Comments

@jNullj
Copy link
Owner

jNullj commented Jul 22, 2022

IMAGE_SIZE=$(xfconf-query -c displays -p /Default/eDP/Resolution)

This assumes that the user has eDP interface to the monitor and that this is the primary screen in use.
Users might have multiple screens and varying name for the interface.

A fix could be to check which is the primary monitor used and making the query to the detected primary monitor.

jNullj added a commit that referenced this issue Jul 22, 2022
Resolution should be selected based on the primary display as there might be multiple displays present.
This also solves the issue of the monitor interface being different for each system while it was hardcoded in the old commit for a specific use case that
would only work for a handful of users who use mainly laptops or other more integrated devices.

This commit adds a function to find the current primary display and uses it for getting the screen resolution to be used when rendering the wallpaper

Fixes issue #1
jNullj added a commit that referenced this issue Jul 22, 2022
Resolution should be selected based on the primary display as there might be multiple displays present.
This also solves the issue of the monitor interface being different for each system while it was hardcoded in the old commit for a specific use case that
would only work for a handful of users who use mainly laptops or other more integrated devices.

This commit adds a function to find the current primary display and uses it for getting the screen resolution to be used when rendering the wallpaper and when setting the rendered wallpaper to the screen

Fixes issue #1
@jNullj
Copy link
Owner Author

jNullj commented Jul 22, 2022

solved with 929467f

@jNullj jNullj closed this as completed Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant