Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cant build container #44

Closed
jNullj opened this issue Oct 19, 2022 · 2 comments
Closed

Cant build container #44

jNullj opened this issue Oct 19, 2022 · 2 comments
Assignees
@jNullj
Labels
bug

Comments

@jNullj
Copy link
Owner

jNullj commented Oct 19, 2022

better-sqlite3 won't build on node 19
for now build using node:18 while better-sqlite3 fixes the issue
@jNullj
Copy link
Owner Author

jNullj commented Oct 28, 2022

Its better to manage node version to avoid this issue in the future
and to allow building the docker image untill the build issue is solved
WiseLibs/better-sqlite3#891

@jNullj jNullj self-assigned this Oct 28, 2022
@jNullj jNullj added the bug label Oct 28, 2022
jNullj added a commit that referenced this issue Oct 28, 2022
@jNullj
Manage dockerfile base image version to avoid build issues
0fcc564 
As part of issue #44 one of the node dependencies (better-sqlite3) was not able to build at latest node version (19)
This fixes docker base image to the older node 18 which still works for that dependency.
The change from latest to a fixed version enables better version control and makes sure this issue will not repeat without prior testing.
Dependbot should be able to offer new versions of node docker image as they update.
@jNullj
Copy link
Owner Author

jNullj commented Jan 27, 2023

Solved in better-sqlite

@jNullj jNullj closed this as completed Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jNullj jNullj

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jNullj