Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

many json tests are failing with ruby 1.9 #44

Closed
pravi opened this issue May 15, 2013 · 2 comments
Closed

many json tests are failing with ruby 1.9 #44

pravi opened this issue May 15, 2013 · 2 comments

Comments

@pravi
Copy link

pravi commented May 15, 2013

$ ruby1.9.1 --version
ruby 1.9.3p194 (2012-04-20 revision 35410) [x86_64-linux]

Full log here http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=623900#64

@pravi
Copy link
Author

pravi commented May 15, 2013

duplicate of #26 , still it would be nice if it was fixed in crack itself

+--- a/test/json_test.rb
++++ b/test/json_test.rb
+@@ -1,6 +1,10 @@
+ # coding: utf-8
+ require 'test_helper'
+ 
++if RUBY_VERSION =~ /1\.9/
++  YAML::ENGINE.yamler = "syck"
++end
++
+ class JsonTest < Test::Unit::TestCase  
+   TESTS = {
+     %q({"data": "G\u00fcnter"})                   => {"data" => "Günter"},

@kiskoza
Copy link
Collaborator

kiskoza commented Jan 26, 2024

Ruby 1.9 is already EOL, the CI is passing for Ruby 2.0+. Feel free to reopen the issue if you still need something to be fixed

@kiskoza kiskoza closed this as completed Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants