Move memoizable cache to injected hash

flippercloud · Apr 27, 2015 · 7f5b905 · 7f5b905
1 parent ec30e1f
commit 7f5b905
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/lib/flipper/adapters/memoizable.rb b/lib/flipper/adapters/memoizable.rb
@@ -5,9 +5,13 @@ module Adapters
     class Memoizable < Decorator
       FeaturesKey = :flipper_features
 
+      # Internal
+      attr_reader :cache
+
       # Public
-      def initialize(adapter)
+      def initialize(adapter, cache = nil)
         super(adapter)
+        @cache = cache || {}
       end
 
       # Public
@@ -68,11 +72,6 @@ def disable(feature, gate, thing)
         result
       end
 
-      # Internal
-      def cache
-        Thread.current[:flipper_memoize_cache] ||= {}
-      end
-
       # Internal: Turns local caching on/off.
       #
       # value - The Boolean that decides if local caching is on.

diff --git a/spec/flipper/adapters/memoizable_spec.rb b/spec/flipper/adapters/memoizable_spec.rb
@@ -7,9 +7,9 @@
   let(:features_key) { described_class::FeaturesKey }
   let(:adapter) { Flipper::Adapters::Memory.new }
   let(:flipper) { Flipper.new(adapter) }
-  let(:cache)   { subject.cache }
+  let(:cache)   { {} }
 
-  subject { described_class.new(adapter) }
+  subject { described_class.new(adapter, cache) }
 
   it_should_behave_like 'a flipper adapter'