Flipper fails with Redis >= 4.8.0

Changelog.md

@@ -1,3 +1,7 @@
+## 0.25.2
+
+* Fix deprecation warnings for Redis >= 4.8.0 (https://github.com/jnunemaker/flipper/pull/660)
+
 ## 0.25.1
 
 ### Additions/Changes

lib/flipper/adapters/redis.rb

@@ -28,13 +28,21 @@ def features
 
       # Public: Adds a feature to the set of known features.
       def add(feature)
-        @client.sadd FeaturesKey, feature.key
+        if redis_sadd_returns_boolean?
+          @client.sadd? FeaturesKey, feature.key
+        else
+          @client.sadd FeaturesKey, feature.key
+        end
         true
       end
 
       # Public: Removes a feature from the set of known features.
       def remove(feature)
-        @client.srem FeaturesKey, feature.key
+        if redis_sadd_returns_boolean?
+          @client.srem? FeaturesKey, feature.key
+        else
+          @client.srem FeaturesKey, feature.key
+        end
         @client.del feature.key
         true
       end
@@ -109,6 +117,10 @@ def disable(feature, gate, thing)
 
       private
 
+      def redis_sadd_returns_boolean?
+        ::Redis.respond_to?(:sadd_returns_boolean) && ::Redis.sadd_returns_boolean
+      end
+
       def read_many_features(features)
         docs = docs_for(features)
         result = {}

spec/flipper/adapters/redis_spec.rb

@@ -6,6 +6,7 @@
 
     options[:url] = ENV['REDIS_URL'] if ENV['REDIS_URL']
 
+    Redis.raise_deprecations = true
     Redis.new(options)
   end