Escaped XML characters in attribute values

[jnunemaker]

I think I’vs found a bug in httparty. When XML is parsed, escaped XML-characters (eg. ampersand) in attribute values are not replaced.

The method REXMLUtilityNode#translate_xml_entities is only used to unescape text values, the attribute values are left plain.

Example:
variant[‘url’] # “http://…/image.jpg?attr=val&attr2=val2”, not “http://…/image.jpg?attr=val&attr2=val2”.

What do you think?

Thanks and ciao,

der Flo

[jnunemaker]

I think it is an issue of REXML::Parsers::BaseParser. Other XML parsers do this unnormalization correctly. Some code says more than thousand words, so see here: http://gist.github.com/89945

I also tested this against ruby-1.9, the same problem.

I forked your crack-repo at github and fixed this issue. It would be nice if you would incorporate my changeset. I’ll send you a pull request.

from der_flo

[der-flo]

Thanks for accepting my patch for crack! Now everything works as expected.

der_flo