-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/lib/httparty/hash_conversions.rb:35:in `normalize_param': warning: URI.escape is obsolete #281
Comments
I'm open to a pull and explanation. :) |
Here's a quite long explanation http://stackoverflow.com/a/13059657. |
This is fixed in latest. |
Hmm... is this fixed? On 0.13.1 (which I believe right now is the latest) I am still seeing the 'obsolete' warning - and URI.escape is still in hash_conversions.rb:35 on the master branch... was this reverted? |
Same here. I'm on 0.13.1 and the problem is still showing up. |
I changed URI.encode to CGI.escape and to get around this. Node, cgi needs to be required. |
I also see this warnings. HashConversions module still uses URI.encode. |
@Olgagr , @howdoicomputer, @the-robear , @jnunemaker |
Any plan to release then? It's been another month and a half. Not fixed in 0.13.3. |
Sorry to pester, but https://rubygems.org/gems/httparty still shows 0.13.3 |
Since a recent install, I'm seeing hundreds of lines re: httparty URI.escape. I call via the soundcloud gem which calls httparty
The offending line is https://github.com/jnunemaker/httparty/blob/master/lib/httparty/hash_conversions.rb#L35
Should we remove the obsolete call?
The text was updated successfully, but these errors were encountered: