Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/lib/httparty/hash_conversions.rb:35:in `normalize_param': warning: URI.escape is obsolete #281

Closed
mrjcleaver opened this issue Mar 12, 2014 · 10 comments

Comments

@mrjcleaver
Copy link

Since a recent install, I'm seeing hundreds of lines re: httparty URI.escape. I call via the soundcloud gem which calls httparty

The offending line is https://github.com/jnunemaker/httparty/blob/master/lib/httparty/hash_conversions.rb#L35

/var/lib/gems/1.9.1/gems/httparty-0.11.0/lib/httparty/hash_conversions.rb:35:in `normalize_param': warning: URI.escape is obsolete
/var/lib/gems/1.9.1/gems/httparty-0.11.0/lib/httparty/hash_conversions.rb:35:in `normalize_param': warning: URI.escape is obsolete
/var/lib/gems/1.9.1/gems/httparty-0.11.0/lib/httparty/hash_conversions.rb:35:in `normalize_param': warning: URI.escape is obsolete
/var/lib/gems/1.9.1/gems/httparty-0.11.0/lib/httparty/hash_conversions.rb:35:in `normalize_param': warning: URI.escape is obsolete

Should we remove the obsolete call?

@jnunemaker
Copy link
Owner

I'm open to a pull and explanation. :)

@triptec
Copy link

triptec commented Jun 5, 2014

Here's a quite long explanation http://stackoverflow.com/a/13059657.

@jnunemaker
Copy link
Owner

This is fixed in latest.

@river-of-code
Copy link

Hmm... is this fixed? On 0.13.1 (which I believe right now is the latest) I am still seeing the 'obsolete' warning - and URI.escape is still in hash_conversions.rb:35 on the master branch... was this reverted?

@howdoicomputer
Copy link

Same here. I'm on 0.13.1 and the problem is still showing up.

@howdoicomputer
Copy link

I changed URI.encode to CGI.escape and to get around this. Node, cgi needs to be required.

@Olgagr
Copy link

Olgagr commented Jan 6, 2015

I also see this warnings. HashConversions module still uses URI.encode.

@rusikf
Copy link

rusikf commented Jan 6, 2015

@Olgagr , @howdoicomputer, @the-robear , @jnunemaker URI.escape is obsolete was fixed in current master( not on release version) and this issue must be closed.

@mrjcleaver
Copy link
Author

Any plan to release then? It's been another month and a half. Not fixed in 0.13.3.

@mrjcleaver
Copy link
Author

Sorry to pester, but https://rubygems.org/gems/httparty still shows 0.13.3

httparty 2015-03-11 09-09-54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants