Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PI_CMD_EVT is unused in pigpiod_if2.c #400

Closed
satoren opened this issue Oct 27, 2020 · 5 comments
Closed

PI_CMD_EVT is unused in pigpiod_if2.c #400

satoren opened this issue Oct 27, 2020 · 5 comments

Comments

@satoren
Copy link

satoren commented Oct 27, 2020

Is this PI_CMD_EVT correct?

{return pigpio_command(pi, PI_CMD_EVM, event, 0, 1);}

@joan2937
Copy link
Owner

Probably not. The equivalent command in pigpio.py uses EVT not EVM.

If you change the code to PI_CMD_EVT does it do what you expect?

@satoren
Copy link
Author

satoren commented Oct 28, 2020

I haven't tried it. I'm working on a compatible library in Node.js. I noticed this when I was referring to the C code at the time.

@guymcswain
Copy link
Collaborator

I'm working on a compatible library in Node.js.

Have a look at pigpio-client. It may save you some time. Most APIs have been implemented, including this one, and it's fairly easy to add others.

@satoren
Copy link
Author

satoren commented Oct 28, 2020

I like type(script).
pigpio-client is not provide type definition.

@guymcswain
Copy link
Collaborator

Fixed in v79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants