Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pigpio will not run on a Pi 5 #589

Open
JinShil opened this issue Nov 7, 2023 · 14 comments
Open

pigpio will not run on a Pi 5 #589

JinShil opened this issue Nov 7, 2023 · 14 comments

Comments

@JinShil
Copy link

JinShil commented Nov 7, 2023

pigpio is hard-coded to not run on a Pi5. See

pigpio/pigpio.c

Lines 7353 to 7356 in c33738a

"+---------------------------------------------------------+\n" \
"|Sorry, this system does not appear to be a raspberry pi. |\n" \
"|aborting. |\n" \
"+---------------------------------------------------------+\n\n");

Do the maintainers plan to update pigpio to support the Pi5? Will this repository entertain pull requests to port pigpio to the pi5?

If not, please update the README and/or archive this repository to let users know.

@guymcswain
Copy link
Collaborator

or archive this repository to let users know

... seems fairly rash given the installed base of a bazillion working devices vs the literal handful of pi5.

Do the maintainers plan to update pigpio to support the Pi5?

I have the aspiration to do so but my first quick read of the available docs suggest this will be a huge task, if not impossible without breaking compatibility.

Will this repository entertain pull requests to port pigpio to the pi65?

Given the potentially monumental task, I think it would be wise to lean into the community for help. At a minimum, we would want to retain architectural oversight of the project.

@sworteu
Copy link

sworteu commented Nov 7, 2023

@guymcswain what would be so different between thos pi's 4 and 4 ? Isn't the pi meant to be backwards compatible?
I'm basicly having the same banner on the systemd pigpiod run (it fails with the same message). All other gpio (raspi-gpio) also fail except for sysfs..

@guymcswain
Copy link
Collaborator

@sworteu pi4 is supported. You need to open a separate issue and give details around the failure.

Isn't the pi meant to be backwards compatible?

Yes but this meaning ends at the os level. pigpio touches the metal.

@sworteu
Copy link

sworteu commented Nov 8, 2023

i tried libgpiod and that seems to work..;)
https://kernel.googlesource.com/pub/scm/libs/libgpiod/libgpiod/+/v0.2.x/README.md
installed trough: sudo apt install gpiod
Note this is not pigpiod but gpiod.
Perhaps some dev may find this useful to resume pigpiod.

@ebaauw
Copy link

ebaauw commented Nov 8, 2023

Maybe better to list the full log:

Nov 08 17:18:45 pi15 systemd[1]: Started pigpiod.service - Daemon required to control GPIO pins via pigpio.
Nov 08 17:18:45 pi15 pigpiod[2059]: 2023-11-08 17:18:45 gpioHardwareRevision: unknown rev code (d04170)
Nov 08 17:18:45 pi15 pigpiod[2059]: 2023-11-08 17:18:45 initCheckPermitted:
Nov 08 17:18:45 pi15 pigpiod[2059]: +---------------------------------------------------------+
Nov 08 17:18:45 pi15 pigpiod[2059]: |Sorry, this system does not appear to be a raspberry pi. |
Nov 08 17:18:45 pi15 pigpiod[2059]: |aborting.                                                |
Nov 08 17:18:45 pi15 pigpiod[2059]: +---------------------------------------------------------+
Nov 08 17:18:45 pi15 pigpiod[2059]: Can't initialise pigpio library

Looks like the revision code for the Pi 5 isn't whitelisted. This is the 8GB model; I think the 4GB model uses c04170.

@ebaauw
Copy link

ebaauw commented Nov 8, 2023

Or more precisely, the code for the BCM2712.

pigpio/pigpio.c

Lines 13791 to 13830 in c33738a

switch ((rev >> 12) & 0xF) /* just interested in BCM model */
{
case 0x0: /* BCM2835 */
pi_ispi = 1;
piCores = 1;
pi_peri_phys = 0x20000000;
pi_dram_bus = 0x40000000;
pi_mem_flag = 0x0C;
break;
case 0x1: /* BCM2836 */
case 0x2: /* BCM2837 */
pi_ispi = 1;
piCores = 4;
pi_peri_phys = 0x3F000000;
pi_dram_bus = 0xC0000000;
pi_mem_flag = 0x04;
break;
case 0x3: /* BCM2711 */
pi_ispi = 1;
piCores = 4;
pi_peri_phys = 0xFE000000;
pi_dram_bus = 0xC0000000;
pi_mem_flag = 0x04;
pi_is_2711 = 1;
clk_osc_freq = CLK_OSC_FREQ_2711;
clk_plld_freq = CLK_PLLD_FREQ_2711;
hw_pwm_max_freq = PI_HW_PWM_MAX_FREQ_2711;
hw_clk_min_freq = PI_HW_CLK_MIN_FREQ_2711;
hw_clk_max_freq = PI_HW_CLK_MAX_FREQ_2711;
break;
default:
DBG(DBG_ALWAYS, "unknown rev code (%x)", rev);
rev=0;
pi_ispi = 0;
break;
}

I would create a PR, but I don't know what values to provide. I suspect the BCM2711 values won't work, now that GPIO is handled by the RP1 southbridge?

@guymcswain
Copy link
Collaborator

pi5 is not supported by pigpio. pi5 is built with a new chip architecture that is incompatible with previous iterations.

@huesla
Copy link

huesla commented Nov 12, 2023

Some thoughts of a user:
Perhaps one could evaluate which features still work on the Pi5 and which do not, and then create a slimmed-down PiGpio version just for the Pi5, to which the (still) missing features are gradually added. This would destroy backwards compatibility, but it would allow users to use still working features (if available) right away and at the same time create a basis for the future.
Unfortunately, I do not have the expertise to support in the development. I am using PiGpio only, especially I2C and Wave Pulsing.

@pelwell
Copy link

pelwell commented Nov 12, 2023

Although I recommend the use of libgpiod, for direct hardware access you may find the RP1 support in pinctrl (https://github.com/raspberrypi/utils) useful as a starting point.

@guymcswain
Copy link
Collaborator

guymcswain commented Nov 14, 2023

... create a slimmed-down PiGpio version just for the Pi5, to which the (still) missing features are gradually added.

I would generally agree with this strategy, however, there are features/capabilities of pigpio that distinguish it from all other gpio libraries: the DMA read engine for sampling gpio and the DMA write engine for pwm, servo and custom waveforms. I have not taken the time to look into it yet but I'm hoping there exists compatible interfaces on Pi5 such as the VPU mailbox registers allowing the DMA peripheral (and supporting peripherals to pace DMA) to be memory mapped. If a more kernel friendly approach is available, that should be explored as well.

@Brunnian
Copy link

I have just experienced this problem too

gpioHardwareRevision: unknown rev code (d04170)

so I am currently snookered

@dhrynyk
Copy link

dhrynyk commented Mar 21, 2024

Simply, I would like to add that I would appreciate seeing pigpio support the Pi 5.

In addition, I would be happy to provide testing support for any update to pigpio. While I'm not familiar with the architecture and design of pigpio, I would be willing to contribute to the development of the Pi 5 support.

@samskiter
Copy link

Is there a beer/coffee fund to which one could contribute to support RPi5 development? Appreciate it's a monumental task, but this is an excellent library and it would be a shame to see the ecosystem of RPi GPIO libraries grow ever larger!

standards

@alessandromrc
Copy link

Between this repo https://github.com/G33KatWork/RP1-Reverse-Engineering and the pinctrl source, it shouldn't be too hard to implement basic GPIO features... on the other hand, re-implementing servo control etc can become a little harder...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants