Null-Safety with 9.0.0 changes #97

radvansky-tomas · 2021-02-28T21:52:05Z

Hi I work with Greg and did requested changes from 9.0.0 branch.
I also resolved that one failing tests we had before. Please review it and try to merge it at least to develop branch.

refactored (& deprecated some) tests to pass

…fall back, incorrect dropdown min height value, handle null value in reactive slider

…rols. ALL TESTS PASS

# Conflicts: # lib/src/widgets/reactive_checkbox.dart # lib/src/widgets/reactive_checkbox_list_tile.dart # lib/src/widgets/reactive_date_picker.dart # lib/src/widgets/reactive_dropdown_field.dart # lib/src/widgets/reactive_form_field.dart # lib/src/widgets/reactive_radio.dart # lib/src/widgets/reactive_radio_list_tile.dart # lib/src/widgets/reactive_status_listenable_builder.dart # lib/src/widgets/reactive_switch.dart # lib/src/widgets/reactive_switch_list_tile.dart # lib/src/widgets/reactive_text_field.dart # lib/src/widgets/reactive_time_picker.dart

joanpablo · 2021-03-01T09:04:02Z

Hi @radvansky-tomas,

Thanks for both of you, and for your work. I will review it. I will let you know soon. I guess then that I should merge this request instead of the one from @gmcdowell ??

radvansky-tomas · 2021-03-01T09:04:56Z

yes correct, thank you for your time

DevNico · 2021-03-04T07:51:53Z

Flutter 2 is out and with it stable null safety a null safe version would be highly appreciated!

joanpablo · 2021-03-04T07:58:34Z

I guys, Hi @radvansky-tomas @gmcdowell @DevNico,

I agree with you, null-safety is a Must now that Flutter 2 is announced. I have been working in stabilizations in type systems because something was broken in the last couple of releases, so that has been my focus. I feel responsible for bringing a stable plugin to the community. I'm waiting for a response to some issues related to the type system, after all those issues are solved my next focus is going to be null-safety and study and merge this PR.

I really appreciate your help. Thanks for your issues and patience.

DevNico · 2021-03-04T08:05:59Z

Could you mention the issues that are blocking for you so we can follow them too?

Also thank you for this great package!

joanpablo · 2021-03-04T08:11:09Z

Type related issues:

Type problems
Error: type 'FormControl' is not a subtype of type 'int' (this one I think is also a missunderstud about Reactive Forms)
value accessor error - type is not a subtype of type 'String' of 'viewValue' (This one is not exactly related to the type system, I think is a misunderstood about ControlValueAccessor features)

Pull Requests related to Type System:

type improvements (I need to give an answer to this PR)

gmcdowell · 2021-03-04T21:18:01Z

@joanpablo thanks for the update and insight into your priorities.
We are going to continue to work on refining our branch (we will consolidate things too) and will keep an eye on your progress.

Do reach out if there is anything we can assist with.

joanpablo · 2021-03-05T11:47:28Z

Thanks @gmcdowell for your kind words, and thanks for the patient of all of you. I have released a couple of versions that solved some issues and I finally have added intl 0.17.0, so the project is not yet null safety but at least it is using the last version of intl.

kuhnroyal · 2021-03-05T12:27:06Z

Really looking forward to this but I think a couple of dynamic things need to be removed before this is possible and valuable. See #102 (comment)

DevNico · 2021-03-17T10:07:00Z

Any updates on when a null safe version will be available? 😄

joanpablo · 2021-03-17T15:41:22Z

Hi guys,

@DevNico I'm working on it. I will need one more week. It's almost done, but because I'm doing two refactorings (null-safety and strict type system) I will need more time.

DevNico · 2021-03-17T15:43:28Z

Alright thanks for the update. Please don't feel rushed, take your time! I just wanted to know how far along you are.

Thank you for this great package!

joanpablo · 2021-03-17T16:21:45Z

Tomorrow I will push my branch so everybody can check my progress. All the library is already migrated to null safety but there are still some tests that are not running because of types of casting issues, I need to solve these casting issues in some way.

cedvdb · 2021-03-18T20:43:59Z

@joanpablo Thanks for the awesome work. I'm interested in using your branch. Even if it's not production ready so I can start the null safety migration. So if it's possible to push it, it would be great

joanpablo · 2021-03-23T18:20:27Z

Hi guys @gmcdowell, @radvansky-tomas, @DevNico, @cedvdb

I have updated the develop branch with a fully functional version of Reactive Forms using the latest version of Flutter with null-safety and a better type system. All tests are running OK. You can check it. I'm still working to improve minor things but I'm very close to release the new version.

@vasilich6107 you can update the reactive widgets library with the latest changes.

vasilich6107 · 2021-03-23T19:25:55Z

Thanks for the update!

vasilich6107 · 2021-03-24T17:46:06Z

@joanpablo I tried to use the dev branch for migration
One thing that I'd like to ask is to give more meaningful name for ReactiveFormField<T, K>

Previously there was only T and this was easy to understand - T is a type of value.
In case of multiple generic values - single letters T and K are not very verbose

joanpablo · 2021-03-24T18:10:09Z

@joanpablo I tried to use the dev branch for migration
One thing that I'd like to ask is to give more meaningful name for ReactiveFormField<T, K>

Previously there was only T and this was easy to understand - T is a type of value.
In case of multiple generic values - single letters T and K are not very verbose

I'm agree with you, I was planning to explain in the class Doc, but what do you suggest?

Something like:

ReactiveFormField<ModelDataType, ViewDataType>

??

joanpablo · 2021-03-24T21:40:34Z

I have release v10.0.0 with null safety.

You can now test it. Now we are in a better position to continuously improve the package :)

Thanks to all of you.

vasilich6107 · 2021-03-25T07:15:07Z

@joanpablo I can suggest
TFormControl(instead of T) which describes the type incoming from FormControl and TField(instead of K) which describes the type expected by field

Here is how control_value_accessor will look like - https://tppr.me/kWbVX

joanpablo · 2021-03-25T08:37:25Z

@joanpablo I can suggest
TFormControl(instead of T) which describes the type incoming from FormControl and TField(instead of K) which describes the type expected by field

Here is how control_value_accessor will look like - https://tppr.me/kWbVX

I have already released it before your suggestion 😅

vasilich6107 · 2021-03-25T09:34:00Z

If my suggestion is ok - I can make PR with update ;-)

cedvdb · 2021-03-26T12:54:25Z

do not prefix it both by T, it's not meaningful either. Just add Type. That's my suggestion. Honestly for generic names you don't really care to be a bit too verbose since it's not part of what's imediatly seen in the public API

joanpablo · 2021-03-26T12:58:28Z

Hi @cedvdb @vasilich6107,

I already put ReactiveFormField<ModelDataType, ViewDataType> is not a traditional name but I think it is quite understandable. I will keep that names for now. Thanks for the suggestions :)

cedvdb · 2021-03-26T15:17:46Z

@joanpablo Those names are fine imho

gmcdowell and others added 13 commits February 16, 2021 13:39

update syntax to support null-safety

ff1e1bc

refactored (& deprecated some) tests to pass

corrects valueChanges getter signature

129c3fd

adjustment to validator signatures

b67aeeb

FormControl nullable

8da4857

Update value accessor null-safety

64735dd

Migrate formField to null-safety

c0edaf9

Update widgets - null control

97e155a

Resolve invalid null-safety operators, add reactive date picker null …

af7ce73

…fall back, incorrect dropdown min height value, handle null value in reactive slider

Correctly add null values into streams, update provider for null cont…

fc712f5

…rols. ALL TESTS PASS

Update dependecies, test example app

fae175e

Return back intl -> null safety

6a5e84c

roll back intl to not clash with reactive_widgets repo

2ae83a1

radvansky-tomas mentioned this pull request Feb 28, 2021

Null Safety updates #95

Closed

joanpablo closed this Mar 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Null-Safety with 9.0.0 changes #97

Null-Safety with 9.0.0 changes #97

radvansky-tomas commented Feb 28, 2021

joanpablo commented Mar 1, 2021

radvansky-tomas commented Mar 1, 2021

DevNico commented Mar 4, 2021

joanpablo commented Mar 4, 2021 •

edited

DevNico commented Mar 4, 2021

joanpablo commented Mar 4, 2021 •

edited

gmcdowell commented Mar 4, 2021

joanpablo commented Mar 5, 2021

kuhnroyal commented Mar 5, 2021

DevNico commented Mar 17, 2021

joanpablo commented Mar 17, 2021

DevNico commented Mar 17, 2021

joanpablo commented Mar 17, 2021

cedvdb commented Mar 18, 2021 •

edited

joanpablo commented Mar 23, 2021 •

edited

vasilich6107 commented Mar 23, 2021

vasilich6107 commented Mar 24, 2021 •

edited

joanpablo commented Mar 24, 2021 •

edited

joanpablo commented Mar 24, 2021

vasilich6107 commented Mar 25, 2021 •

edited

joanpablo commented Mar 25, 2021 •

edited

vasilich6107 commented Mar 25, 2021

cedvdb commented Mar 26, 2021

joanpablo commented Mar 26, 2021

cedvdb commented Mar 26, 2021

Null-Safety with 9.0.0 changes #97

Null-Safety with 9.0.0 changes #97

Conversation

radvansky-tomas commented Feb 28, 2021

joanpablo commented Mar 1, 2021

radvansky-tomas commented Mar 1, 2021

DevNico commented Mar 4, 2021

joanpablo commented Mar 4, 2021 • edited

DevNico commented Mar 4, 2021

joanpablo commented Mar 4, 2021 • edited

gmcdowell commented Mar 4, 2021

joanpablo commented Mar 5, 2021

kuhnroyal commented Mar 5, 2021

DevNico commented Mar 17, 2021

joanpablo commented Mar 17, 2021

DevNico commented Mar 17, 2021

joanpablo commented Mar 17, 2021

cedvdb commented Mar 18, 2021 • edited

joanpablo commented Mar 23, 2021 • edited

vasilich6107 commented Mar 23, 2021

vasilich6107 commented Mar 24, 2021 • edited

joanpablo commented Mar 24, 2021 • edited

joanpablo commented Mar 24, 2021

vasilich6107 commented Mar 25, 2021 • edited

joanpablo commented Mar 25, 2021 • edited

vasilich6107 commented Mar 25, 2021

cedvdb commented Mar 26, 2021

joanpablo commented Mar 26, 2021

cedvdb commented Mar 26, 2021

joanpablo commented Mar 4, 2021 •

edited

joanpablo commented Mar 4, 2021 •

edited

cedvdb commented Mar 18, 2021 •

edited

joanpablo commented Mar 23, 2021 •

edited

vasilich6107 commented Mar 24, 2021 •

edited

joanpablo commented Mar 24, 2021 •

edited

vasilich6107 commented Mar 25, 2021 •

edited

joanpablo commented Mar 25, 2021 •

edited