willSave and didSave notifications are always sent

[astoff]

The server can specify in TextDocumentClientCapabilities if it wants to receive these notifications.

[nemethf]

I think TextDocumentClientCapabilities is sent by the client. The server can declare its support for willSave in ServerCapabilities.textDocumentSync (which is a TextDocumentSyncOptions object).

But you're right in general, it is a bug that eglot doesn't check the capabilities of the server before sending :textDocument/willSave.

The server can declare its lack of support for didSave by omitting the save attribute from textDocumentSync. Eglot doesn't seem to check this either.

[joaotavora]

But you're right in general, it is a bug that eglot doesn't check the capabilities of the server before sending :textDocument/willSave.

Yes, I believe this is a bug. But is it hurting anyone?

[nemethf]

Commit 21ab73c fixed this.