Add pyright language server support for python-mode #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joaotavora This patch is trivial, and pyright seems like free software (MIT License), so I don't see anything that would stop this from going in. WDYT? |
|
Looks good yes, @skangas. Here I would press "Squash and merge" and edit the commit message as usual. Thanks. |
* eglot.el (eglot-server-programs): Add pyright support for python-mode. * README.md: Document the above change. Copyright-paperwork-exempt: Yes
|
Now merged to master. Thanks for the contribution! |
hlissner
pushed a commit
to doomemacs/doomemacs
that referenced
this pull request
Jan 27, 2022
joaotavora/eglot@fd27cdc8f9e8 adds Pyright support to Eglot, so these lines can be removed. Amend: 34cb632 Revert: #5355 Ref: joaotavora/eglot@fd27cdc8f9e8 Ref: joaotavora/eglot#742
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joaotavora pyright Language Server Protocol for Python implementation by Microsoft becomes more popular recent days. Good to see it's supported here.