Mark eglot completions as non-exclusive #770
Conversation
|
Hello. This is interesting. Do you know reads this property, how it works? Can you point me to some documentation? |
|
Discovered this while trying to stop using company-mode. It seems to work correctly but could be incredibly specific to my configuration. I use consult-completion-in-region as my completion-in-region-function. My only two completion-at-point-functions are eglot-completion-at-point and cape-dabbrev to turn dabbrev into a capf. |
|
Alright, I didn't know about that option, and it looks like a fine idea if indeed it does help you. Can you format the commit message like most others (80 chars, etc), and tell me if you have a FSF copyright assignment? (your simple patch can go in regardless). This will help me press the big green button. |
Add a property to the eglot-completion-at-point results marking it as non-exclusive. This will allow completion to fall back to other less precise completion backends if eglot returns no results (e.g. dabbrev).
|
Fixed the commit message line length. No FSF copyright assignment. |
|
Thanks! You should get a FSF copyright assignment if you plan on contributing more to Eglot and or Emacs. |
…exclusive" Add :exclusive 'no to eglot-completion-at-point results marking it as non-exclusive. This will allow completion to fall back to other less precise completion backends (e.g. dabbrev) if Eglot's returns no results. * eglot.el (eglot-completion-at-point): Set :exclusive to 'no Copyright-paperwork-exempt: Yes
…exclusive" Add :exclusive 'no to eglot-completion-at-point results marking it as non-exclusive. This will allow completion to fall back to other less precise completion backends (e.g. dabbrev) if Eglot's returns no results. * eglot.el (eglot-completion-at-point): Set :exclusive to 'no Copyright-paperwork-exempt: Yes
Add :exclusive 'no to eglot-completion-at-point results marking it as non-exclusive. This will allow completion to fall back to other less precise completion backends (e.g. dabbrev) if Eglot's returns no results. * eglot.el (eglot-completion-at-point): Set :exclusive to 'no Copyright-paperwork-exempt: Yes #770: joaotavora/eglot#770
Add :exclusive 'no to eglot-completion-at-point results marking it as non-exclusive. This will allow completion to fall back to other less precise completion backends (e.g. dabbrev) if Eglot's returns no results. * eglot.el (eglot-completion-at-point): Set :exclusive to 'no Copyright-paperwork-exempt: Yes GitHub-reference: close joaotavora/eglot#770
Add a property to the eglot-completion-at-point results marking it as non-exclusive. This will allow completion to fall back to other less precise completion backends if eglot returns no results (e.g. dabbrev)