Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad defsystem indentation #637

Open
dieggsy opened this issue Apr 12, 2024 · 5 comments
Open

Bad defsystem indentation #637

dieggsy opened this issue Apr 12, 2024 · 5 comments

Comments

@dieggsy
Copy link
Contributor

dieggsy commented Apr 12, 2024

Sly now appears to indent defsystems like this:

(defsystem :slynk
    :serial t
  :components
  ...)

Instead of:

(defsystem :slynk
  :serial t
  :components
  ...)

Which aligns with Slime, ASDF documentation, and slynk's own defsystems.

@dieggsy dieggsy changed the title Bad defsystem indentation? Bad defsystem indentation Apr 12, 2024
@mdbergmann
Copy link
Contributor

Hmm, it aligns as it should here.
Do you have an inferior lisp session open?

@dieggsy
Copy link
Contributor Author

dieggsy commented Apr 12, 2024

Oh. Interesting. I do have an inferior lisp session open. Maybe it's something about my configuration then? I thought I tested this in a plain environment, but I can double check.

@mdbergmann
Copy link
Contributor

I do not know. I just observed and wanted to mention that without an inferior lisp session things like, i.e. &rest, &body are differently indented.

@dieggsy
Copy link
Contributor Author

dieggsy commented Jun 10, 2024

I do see this in a plain environment, with a sly connection started, but only under Allegro Common Lisp it seems. For example, it will happen with this minimal init:

;;; -*- lexical-binding: t -*-
(require 'package)
(add-to-list 'package-archives '("melpa" . "https://melpa.org/packages/") t)
(package-initialize)

;; This provides a nice configuration interface for installing and configuring
;; packages from your .emacs
(unless (package-installed-p 'use-package)
  (package-refresh-contents)
  (package-install 'use-package))

(use-package sly
  :ensure t
  :config
  ;; can change to your own path
  (setq inferior-lisp-program "alisp"))

But not when i set inferior-lisp-program to sbcl. Unless I C-u sly and start an alisp connection, at which point the indentation again goes bad (and doesn't seem to revert even if I switcch back to the sbcl connection).

@joaotavora
Copy link
Owner

In the beginning of a Lisp session, SLY and Swank exchange information about how how to indent certain macros. Maybe that communication isn't happening as it should when alisp is used. I'm sorry, I don't remember more details, but maybe this helps someone investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants