Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception causes all over the codebase #1070

Merged
merged 1 commit into from Jun 29, 2020

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Jun 17, 2020

@ogrisel
This is a continuation of #1067

@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #1070 into master will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1070      +/-   ##
==========================================
- Coverage   94.45%   94.39%   -0.06%     
==========================================
  Files          47       47              
  Lines        6849     6849              
==========================================
- Hits         6469     6465       -4     
- Misses        380      384       +4     
Impacted Files Coverage Δ
joblib/_multiprocessing_helpers.py 80.00% <ø> (ø)
joblib/_dask.py 94.89% <100.00%> (ø)
joblib/_parallel_backends.py 94.92% <100.00%> (ø)
joblib/disk.py 92.06% <100.00%> (ø)
joblib/func_inspect.py 91.61% <100.00%> (ø)
joblib/logger.py 86.84% <0.00%> (-1.32%) ⬇️
joblib/memory.py 95.39% <0.00%> (-0.55%) ⬇️
joblib/_store_backends.py 90.76% <0.00%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac0f152...7cbb3ab. Read the comment docs.

Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @cool-RR !

@ogrisel ogrisel merged commit 1cd2202 into joblib:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants