Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to free(dI3dLz) in Staeckel actionAngle_ActionsFreqsAngles #328

Closed
jobovy opened this issue Dec 21, 2017 · 0 comments
Closed

Need to free(dI3dLz) in Staeckel actionAngle_ActionsFreqsAngles #328

jobovy opened this issue Dec 21, 2017 · 0 comments
Assignees
@jobovy
Labels
bug Fixed in branch low priority

Comments

@jobovy
Copy link
Owner

jobovy commented Dec 21, 2017

At this line, dI3dlz is malloc'ed, but not free'ed

galpy/galpy/actionAngle_src/actionAngle_c_ext/actionAngleStaeckel.c

Line 814 in e22dcbc

free(dI3dJz);

Would perhaps help to clean up the Staeckel C code in general to avoid duplication...
@jobovy jobovy self-assigned this Dec 21, 2017
@jobovy jobovy changed the title Need to free(dI3dLz) in Staeckel actionAngleActionsFreqsAngles Need to free(dI3dLz) in Staeckel actionAngle_ActionsFreqsAngles Jan 1, 2018
@jobovy jobovy closed this as completed in 549508a Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jobovy jobovy

Labels
bug Fixed in branch low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jobovy