-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom tags #11
Comments
Hi @ericuldall I removed validation, since I expect the developers to understand what they're doing ;) The validation is needed where the software's decisions are not straight forward. Your example would look like this now: const metricsMiddleware = promBundle({includeMethod: true, customLabels: customTags}); ... and transformLabels can be used for a dynamicly changing labels. See https://github.com/jochen-schweizer/express-prom-bundle/blob/master/advanced-example.js Hope it's not too much of a change compared to your intention. |
Is the update available on npm? |
I see the update to the docs there. Thanks for adding this! It will be very useful. |
Is it possible to use transformLabels to add a custom tag depending on the response body? In my case I need a custom label to track GraphQL error metrics. And the list of errors is returned in the response body together with the data. |
why not? The signature is: I'd say |
My question was a bit premature, sorry. It was born from the lack of understanding of how express works, and the intricacies of reading a response body in a middleware. I did end up putting errors from response body on to If anyone stumbles upon this issue in the same situation I was in, I used this to read the body:
Inspired by this answer https://stackoverflow.com/a/33881887/6493014 |
It would be a great feature to allow custom tags when applying this middleware. Perhaps the end user has some environment variables they would like to be scraped by prometheus to improve dashboard display granularity.
Example:
Then in our output it would be:
Is this something that would be accepted as a PR?
The text was updated successfully, but these errors were encountered: