Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating dependencies #3

Closed
jybleau opened this issue Nov 23, 2016 · 2 comments
Closed

updating dependencies #3

jybleau opened this issue Nov 23, 2016 · 2 comments

Comments

@jybleau
Copy link

jybleau commented Nov 23, 2016

Hello,

Is there a blocking reason why dependencies, like prom-client, are outdated? (current version is 6, package version is 3)

If no, would you like a pull request on that matter?

Thanks

@disjunction
Copy link
Collaborator

Hi,
thanks for pointing it out!

The new version of prom-bundle partially overlaps with the functionality of express-prom-bundle, namely by providing default metrics and an internal metrics registry. That's why it's not just version bumping in package.json.

Thanks for offering help, but I'll make an upgrade soon myself.

@disjunction
Copy link
Collaborator

Upgrade done in 08d98b4, already published on npm

For compatibility reasons the default metrics introduced in prom-client will NOT be provided automatically. If you still want them, use keepDefaultMetrics option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants