Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soft skeleton #25

Closed
etienne87 opened this issue Oct 25, 2022 · 2 comments
Closed

soft skeleton #25

etienne87 opened this issue Oct 25, 2022 · 2 comments

Comments

@etienne87
Copy link

Hi, thanks for the great package.

I would like to understand why you perform soft erosion using a sequence of 3 min_pooling with separable filters. Can't we instead just use one big min_pool (using -F.max_pool3d(-img, kernel_size=(3,3,3),stride=1,padding=1) ) ?

@jocpae
Copy link
Owner

jocpae commented Oct 25, 2022

Hi,
that is a very good question. As discussed in the paper, our skeletonization is not perfect. It is a pure approximation of a skeleton using max and min pooling, where we cannot guarantee a correct skeleton. We tested various filters and kernels for the pooling operations, and found that it sometimes made a difference on a specific dataset. We just chose to present one version in this repo.

In short: your suggestion may very well work for your specific problem :)

@etienne87
Copy link
Author

understood, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants