fix(@plaiceholder/next): add sharp to webpack externals

joe-bell · Jun 13, 2021 · 76a49be · 76a49be
1 parent a3720a3
commit 76a49be
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 9 deletions.
diff --git a/examples/next/next.config.js b/examples/next/next.config.js
@@ -4,13 +4,6 @@ module.exports = withPlaiceholder({
   images: {
     domains: ["images.unsplash.com"],
   },
-  webpack: (config) => {
-    config.externals.push({
-      sharp: "commonjs sharp",
-    });
-
-    return config;
-  },
   future: {
     webpack5: true,
   },

diff --git a/packages/next/src/index.ts b/packages/next/src/index.ts
@@ -1,5 +1,17 @@
-export const withPlaiceholder = (config) => {
+export const withPlaiceholder = (nextConfig) => {
   require("sharp");
 
-  return config;
+  return Object.assign({}, nextConfig, {
+    webpack(config, options) {
+      config.externals.push({
+        sharp: "commonjs sharp",
+      });
+
+      if (typeof nextConfig?.webpack === "function") {
+        return nextConfig.webpack(config, options);
+      }
+
+      return config;
+    },
+  });
 };