Guru highlighting colour makes identifier text hard to read

[mkraft]

Guru highlighting makes the text of the highlighted identifier difficult to read with the following popular theme combination:

UI Theme: Atom Dark
Syntax Theme: Solarized Dark

It's a great feature that I want to keep enabled, but I also don't want to change my theme combination. Could we please make it configurable or change the colour for everyone?

[joefitzgerald]

This is actually a theme issue; we're just using the selected background color (

go-plus/styles/go-plus-guru.atom-text-editor.less

Line 4 in 5376e68

background-color: @background-color-selected;

). atom/solarized-dark-syntax#85 seems to describe how it should look with those combinations. The question is: why does yours look different?

[zmb3]

I'm noticing the same behavior with the solarized light syntax theme.

[zmb3]

It turns out @background-color-selected is for selections in the UI (tree-view, for example). It is not the background color for selected text. For that, we should be using @syntax-selection-color from syntax-variables.less.

Current behavior (@background-color-selected):

With fix (@syntax-selection-color):

Should be a super quick fix. I'll get to it tonight if someone doesn't beat me to it.