Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

go modules support #761

Open
lelvisl opened this issue Mar 27, 2018 · 19 comments
Open

go modules support #761

lelvisl opened this issue Mar 27, 2018 · 19 comments
Assignees
Labels

Comments

@lelvisl
Copy link

lelvisl commented Mar 27, 2018

Hi!
Can you add vgo instead of go to the configuration?

@joefitzgerald
Copy link
Owner

Yes, this makes sense.

@lelvisl
Copy link
Author

lelvisl commented Mar 27, 2018

thx!

@lelvisl
Copy link
Author

lelvisl commented May 4, 2018

some news?

@zmb3
Copy link
Collaborator

zmb3 commented May 4, 2018

No updates at this point. I'd like to wait to get more experience with vgo both personally and see more use in the wild to help inform what to build.

@g42sh
Copy link

g42sh commented May 17, 2018

+1

@zmb3 zmb3 changed the title vgo support go modules support Jul 17, 2018
@hugollm
Copy link

hugollm commented Aug 25, 2018

I'm using go 1.11 and go-plus actually modified my project's go.mod to install the tooling.
Would make sense to install only on the workspace, right? Without modifying the project's dependencies.
Not sure if it's even possible to chose 🤔

@nick-phillips-dev
Copy link

I updated to go 1.11 and I'm having some issues with guru and godef. They are unable to find declarations based on the new cache system.

e.g.
image

@zmb3
Copy link
Collaborator

zmb3 commented Aug 30, 2018

We are working with tool maintainers to get everything updated to work with modules. Support for modules should gradually improve in the coming weeks.

In the meantime, the best workaround is to clone the module into your GOPATH and use go mod -vendor to populate a vendor directory.

@nick-phillips-dev
Copy link

@zmb3 Thanks for the response. I thought that would work as well but still getting the same error. Any thing else I can try?

@zmb3
Copy link
Collaborator

zmb3 commented Aug 30, 2018

@hyprnick is your GO111MODULE env var set? In vendor mode, you should leave that to auto or off. As long as it's not set to on, the tools shouldn't know a difference.

@nick-phillips-dev
Copy link

@zmb3 It is unset. I moved my project outside of the GOPATH once I upgraded to 1.11.

@nick-phillips-dev
Copy link

@zmb3 I ended up downgrading back to 1.10 for the time being.

From what I saw, it doesn't look like gocode is working on 1.11 - see here mdempsky/gocode#48

@jingminglang
Copy link

+1

@bensussman
Copy link

+1 my team just migrated to go modules and atom w/ go-plus went from being a dream to use to completely unusable overnight.

@zmb3
Copy link
Collaborator

zmb3 commented Oct 6, 2018

@bensussman - hear you loud and clear. You're not alone - I too struggle to use go-plus with modules, and the story is the same in many other editors. The tools that editors rely upon to provide all the fancy features you've come to love simply aren't there yet.

The tools are starting to add support, but even the ones that work are too slow to provide a nice experience. We're keeping a close eye on all of the tools and will work to incorporate them when the time is right.

For now, the best recommendation I have for you is to continue to put your code in a GOPATH and run go mod vendor to populate a vendor directory. The tools will work as-is and you'll at least have a productive dev environment.

@tekkamanendless
Copy link

I found that switching from mdempsky to stamblerre for gocode fixed autocomplete, which made my life a whole lot better:
go get -u github.com/stamblerre/gocode

@zmb3
Copy link
Collaborator

zmb3 commented Jan 21, 2019

If you're watching this issue you could help by letting us know which features are not working with modules. As far as I can tell build/test, documentation, go to definition, and autocomplete (with stamblerre/gocode) should all work.

@joefitzgerald
Copy link
Owner

PR #866 switches to use https://github.com/stamblerre/gocode by default.

@gnu-user
Copy link

Switching to using the fork by stamblerre solved the problem. Is anyone able to update the documentation under "Installing Missing Tools" for the Atom package page? https://atom.io/packages/go-plus

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

10 participants