Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider recognizing newlines #7

Open
lread opened this issue May 18, 2022 · 0 comments
Open

Consider recognizing newlines #7

lread opened this issue May 18, 2022 · 0 comments

Comments

@lread
Copy link

lread commented May 18, 2022

Currently

Doric does nothing special with newlines.

But what if..

...it did and rendered content in the appropriate table cell even when it contained newlines.

For example a table rendered by doric but with some pre-processing added to wrap the multi-line java version:

|-------------------+-----------------------------------------------------------------------------------------------------+-----------------------------------------------------------------------|
|        Name       |                                               Version                                               |                                  App                                  |
|-------------------+-----------------------------------------------------------------------------------------------------+-----------------------------------------------------------------------|
| Java              | openjdk version "11.0.15" 2022-04-19                                                                | /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.15-10/x64/bin/java |
|                   | OpenJDK Runtime Environment Temurin-11.0.15+10 (build 11.0.15+10)                                   |                                                                       |
|                   | OpenJDK 64-Bit Server VM Temurin-11.0.15+10 (build 11.0.15+10, mixed mode)                          |                                                                       |
| Leiningen         | Leiningen 2.9.8 on Java 11.0.15 OpenJDK 64-Bit Server VM                                            | /opt/hostedtoolcache/Leiningen/latest.0.0-3-6/x64/bin/lein            |
| Babashka          | babashka v0.8.2                                                                                     | /home/runner/work/_temp/e3a6c16b-fba7-48dc-aea4-3f7a3814df28/bb       |
| Chrome            | Google Chrome 101.0.4951.54                                                                         | /usr/bin/google-chrome                                                |
| Chrome Webdriver  | ChromeDriver 101.0.4951.41 (93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}) | /usr/bin/chromedriver                                                 |
| Firefox           | Mozilla Firefox 99.0                                                                                | /usr/bin/firefox                                                      |
| Firefox Webdriver | geckodriver 0.31.0 (b617178ef491 2022-04-06 11:57 +0000)                                            | /usr/bin/geckodriver                                                  |
|-------------------+-----------------------------------------------------------------------------------------------------+-----------------------------------------------------------------------|

Next Steps

If you like this idea as much as I do, and after we work out any details, I'd be happy to follow up with a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant