Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classes are checked after running error-hook #7

Open
danlarkin opened this issue Mar 5, 2015 · 1 comment
Open

classes are checked after running error-hook #7

danlarkin opened this issue Mar 5, 2015 · 1 comment

Comments

@danlarkin
Copy link

In the catch block [1] inside robert.bruce/retry, error-hook is called on t and THEN try-again? is called, but this means that the error hook can't know the type of Throwable it's getting - even if :classes lists only one.

I propose the evaluation order be reversed.

@joegallo
Copy link
Owner

joegallo commented May 8, 2015

I have thought about this a lot, and I can totally see that there's a need for a hook that has access to the thing that you're asking for, but it's different than what the error-hook is for.

I'm going to noodle on this a bit more and see if I can get something in that gives you what you're asking for, but leaves the error-hook as it is.

Thanks for the message!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants