Changed update_entity to update_token #117
Conversation
There was a problem hiding this comment.
@neilong31 can you re run tox & check the linting errors, & update the CHANGELOG.md referencing bothupdate_entity & register_entity being renamed, thank you.
| @@ -99,7 +99,7 @@ def register(): | |||
| def login(): | |||
| # I'm authorized & updating my token! | |||
| return jsonify({ | |||
| "token": jwt_routes.update_entity(entity_id=1) | |||
There was a problem hiding this comment.
If you can install Sphinx & run the following:
make html
I will update the Pipfile to add Sphinx as a dev dep in my Pr either today or tomorrow, thank you.
There was a problem hiding this comment.
Okay I'll try and give it a go!
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
=======================================
Coverage 88.48% 88.48%
=======================================
Files 7 7
Lines 278 278
Branches 31 31
=======================================
Hits 246 246
Misses 25 25
Partials 7 7
Continue to review full report at Codecov.
|
CHANGELOG.md
Outdated
|
|
||
| - Renamed the `update_entity` public method to be called `update_token` [Issue #114](https://github.com/joegasewicz/Flask-JWT-Router/issues/114) | ||
|
|
There was a problem hiding this comment.
remove spaces after list items
|
HI @neilong31 Thanks for the changes, could you just look at @kousikmitra comment and then i can merge your excellent work in, thank you. |
|
Thanks @neilong31 for the good work. |
Fixes #114
Every instance of the method update_entity has been renamed or is calling update_token now.