Add Models to JWTRoutes class & init_app method #119 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 88.01% 88.48% +0.47%
==========================================
Files 6 7 +1
Lines 267 278 +11
Branches 31 31
==========================================
+ Hits 235 246 +11
Misses 25 25
Partials 7 7
Continue to review full report at Codecov.
|
joegasewicz
commented
Dec 9, 2019
| @@ -8,6 +8,7 @@ pytest = "*" | |||
| twine = "*" | |||
| pyjwt = "*" | |||
| Flask-SQLAlchemy = "*" | |||
| Sphinx = "*" | |||
There was a problem hiding this comment.
This is just for running the docs locally, this actually gets run automatically when the code is merged (we don't source control the build dir)
joegasewicz
commented
Dec 9, 2019
| @@ -1,29 +1,32 @@ | |||
| from flask_jwt_router._jwt_routes import JwtRoutes | |||
There was a problem hiding this comment.
Improved the tests for extensions .. should only be testing the actual extensions class...
kousikmitra
approved these changes
Dec 10, 2019
|
thanks you @kousikmitra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to the public api the model declarations. We will continue to provide the option to declare models on Flask's config.
@kousikmitra @neilong31 would be grateful for a review, thank you