Testing: make "failBecauseExpectedAssertionErrorWasNotThrown()" in test throw something else than AssertionError...

[fge]

(and find a shorter name for it?)

The problem is that writing tests is rather unnatural compared to, for instance, the core API's "failBecauseExc..." Argh, can't say it. shouldHaveThrown().

Since it throws an AssertionError, if we write, in a test:

try {
    myAssertionHereWhichFails();
    failBecauseExpectedAssertionErrorWasNotThrown();
} catch (AssertionError e) {
    someVerifyCode();
}

even though the naturally expected result that the verification code was not hit, it is.

Instead one has to write this rather unwieldy code:

try {
    myAssertionHereWhichFails();
    return;
} catch (AssertionError e) {
    someVerifyCode();
    return;
}
failBecauseExpectedAssertionErrorWasNotThrown();

Why not make it throw a custom AssertionErrorExpectedException instead?

Also, why not an alternate name of wasExpectingAssertionError()?

[fge]

Submitted a patch on my topic/jsr203 branch which does exactly what I suggested. Comments?