Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands with 3+ arguments don't work #19

Closed
danhunsaker opened this issue Dec 31, 2012 · 1 comment
Closed

Commands with 3+ arguments don't work #19

danhunsaker opened this issue Dec 31, 2012 · 1 comment
Milestone

Comments

@danhunsaker
Copy link
Contributor

I attempted to use SETEX and found, to my dismay, that it wasn't getting all of the arguments it wanted. Upon inspection of the __call() method, I quickly discovered why. I have a simple fix for this, which I will issue a pull request for in just a minute. I don't think it will fix Issue #18 (though it might provide a cleaner workaround), so I'm creating a new issue for it here.

Basically, the fix is to use implode() on the arguments array, since the logic in _encode_request() already properly handles an argument list separated by spaces. This is only done, of course, if the first argument is not an array. The second argument to _encode_request() is not sent in this case.

@joelcox
Copy link
Owner

joelcox commented Jan 2, 2013

Closed per #20. Thanks again.

@joelcox joelcox closed this as completed Jan 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants