Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only able to pause when a stack is selected. #85

Open
joelday opened this issue Jul 17, 2019 · 3 comments
Open

Only able to pause when a stack is selected. #85

joelday opened this issue Jul 17, 2019 · 3 comments
Assignees
Labels
debugger enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@joelday
Copy link
Owner

joelday commented Jul 17, 2019

  1. VSCode won't send a pause command when there is no stack selected. (The majority of the time, there are none running long enough to actually select.)
  2. When we do pause, (not via breakpoint), we send a stop event immediately, but no stop event to tell the client which stack we've stopped on once a stack is actually stopped on.

Side note: @Scrivener07 Should we be treating actively executing stacks as our "threads" or should we be listing all script attachments, where each is 'paused' unless there is an active stack. I assume this list would be pretty big. Active ones could be sorted to the top? Unsure.

@joelday joelday added the bug Something isn't working label Jul 17, 2019
@joelday joelday self-assigned this Jul 17, 2019
@joelday
Copy link
Owner Author

joelday commented Jul 17, 2019

Depends on microsoft/debug-adapter-protocol#66

@joelday joelday added debugger question Further information is requested labels Jul 17, 2019
@slacksystem
Copy link

I'm a bit confused by this sorry. When I set breakpoints in a file, they don't pause. Is this saying that that is due to me having to select that script in the call stack section first and is there a solution that will allow me to do so since it doesn't stay on the screen for more than a moment? @joelday I was confused by our comment on July 17

@joelday
Copy link
Owner Author

joelday commented Sep 27, 2023

microsoft/debug-adapter-protocol#66 was closed as by design, so we need to add a phony "main" thread used exclusively for handling pause requests that result in breaking on the first execution that follows. Will need to make sure that the phony thread is ignored otherwise.

@joelday joelday added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers and removed bug Something isn't working question Further information is requested labels Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debugger enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants