Skip to content
This repository has been archived by the owner on Mar 21, 2021. It is now read-only.

Why do we need GraphQL? #39

Open
stevenvachon opened this issue Jul 27, 2017 · 3 comments
Open

Why do we need GraphQL? #39

stevenvachon opened this issue Jul 27, 2017 · 3 comments

Comments

@stevenvachon
Copy link

stevenvachon commented Jul 27, 2017

It seems a little heavy (and opinionated) to achieve what Nightmare.js does.

@joelgriffith
Copy link
Owner

I agree that it's overstepping the boundaries of what a driver should probably do (in this case just parity with Nightmare.js). However I hate having to restrict access to just folks using JavaScript or TypeScript, and the easiest way to get other runtimes onboard is by offering an interface like GraphQL so that anyone can drive the browser.

Does seem like too much for this repo. I might use something like lerna to split up the repositories so it doesn't have multiple objectives.

@basarat
Copy link
Contributor

basarat commented Jul 31, 2017

I agree that it is too much.

However I hate having to restrict access to just folks using JavaScript or TypeScript, and the easiest way to get other runtimes onboard is by offering an interface like GraphQL

A simple TypeScript interface shared by implementations would serve the same purpose.

Does seem like too much for this repo. I might use something like lerna to split up the repositories so it doesn't have multiple objectives.

I would delete it. Mostly because I think it detracts from the great (best) chrome automation you have done here 🌹

@dbalatero
Copy link

dbalatero commented Sep 12, 2017

I'm considering using it to implement a headless Chrome driver for Capybara (ruby/rspec) that doesn't rely on the really sketchy Selenium implementation we have. I'm fine with splitting it though, but just adding this as a datapoint for what I find useful about it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants