You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First, thanks for writing this library, it's a great effort.
Sometimes, for a number of reasons (browser disconnects, using xit or xdescribe) when no tests are included in the karma test suite run, and you run them using this library, it creates a default spec for each thread. This seems a little unorthodox and makes you think all tests have run successfully, unless you look at the number or the description of the test.
The lines of code are here:
if (!hasSpecs) {
ctx.describe('[karma-parallel] Add single test to prevent failure', function() {
(ctx.it || ctx.specify).call(ctx, 'should prevent failing by having sucessful tests', function(){});
});
}
First, thanks for writing this library, it's a great effort.
Sometimes, for a number of reasons (browser disconnects, using
xit
orxdescribe
) when no tests are included in the karma test suite run, and you run them using this library, it creates a default spec for each thread. This seems a little unorthodox and makes you think all tests have run successfully, unless you look at the number or the description of the test.The lines of code are here:
See https://github.com/joeljeske/karma-parallel/blob/master/lib/karma-parallelizer.js#L151
Can I ask that we remove this behaviour if no specs are found?
This is changing the basic implementation of the test runner.
The text was updated successfully, but these errors were encountered: