Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Specs per thread when no specs found - confusing! #30

Closed
rob-pocklington-a139759 opened this issue Oct 24, 2018 · 0 comments
Closed

Comments

@rob-pocklington-a139759
Copy link

rob-pocklington-a139759 commented Oct 24, 2018

First, thanks for writing this library, it's a great effort.

Sometimes, for a number of reasons (browser disconnects, using xit or xdescribe) when no tests are included in the karma test suite run, and you run them using this library, it creates a default spec for each thread. This seems a little unorthodox and makes you think all tests have run successfully, unless you look at the number or the description of the test.

The lines of code are here:

 if (!hasSpecs) {
        ctx.describe('[karma-parallel] Add single test to prevent failure', function() {
          (ctx.it || ctx.specify).call(ctx, 'should prevent failing by having sucessful tests', function(){});
        });
}

See https://github.com/joeljeske/karma-parallel/blob/master/lib/karma-parallelizer.js#L151

Can I ask that we remove this behaviour if no specs are found?

This is changing the basic implementation of the test runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant